timoreo/quirc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

otsu: Use unsigned for the pixel numbers

Browse source 
Because singed numbers don't make sense here.
This commit is contained in:
YAMAMOTO Takashi 2021-04-08 13:35:12 +09:00
parent de68db7b69
commit ea9b6ee5ef
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/identify.c
View file

@ -177,13 +177,13 @@ static void flood_fill_seed(struct quirc *q, int x, int y, int from, int to,
static uint8_t otsu(const struct quirc *q) static uint8_t otsu(const struct quirc *q)
{ {
int numPixels = q->w * q->h; unsigned int numPixels = q->w * q->h;
// Calculate histogram // Calculate histogram
unsigned int histogram[UINT8_MAX + 1]; unsigned int histogram[UINT8_MAX + 1];
(void)memset(histogram, 0, sizeof(histogram)); (void)memset(histogram, 0, sizeof(histogram));
uint8_t* ptr = q->image; uint8_t* ptr = q->image;
int length = numPixels; unsigned int length = numPixels;
while (length--) { while (length--) {
uint8_t value = *ptr++; uint8_t value = *ptr++;
histogram[value]++; histogram[value]++;
@ -198,7 +198,7 @@ static uint8_t otsu(const struct quirc *q)
// Compute threshold // Compute threshold
double sumB = 0; double sumB = 0;
int q1 = 0; unsigned int q1 = 0;
double max = 0; double max = 0;
uint8_t threshold = 0; uint8_t threshold = 0;
for (i = 0; i <= UINT8_MAX; ++i) { for (i = 0; i <= UINT8_MAX; ++i) {
@ -208,7 +208,7 @@ static uint8_t otsu(const struct quirc *q)
continue; continue;
// Weighted foreground // Weighted foreground
const int q2 = numPixels - q1; const unsigned int q2 = numPixels - q1;
if (q2 == 0) if (q2 == 0)
break; break;