timoreo/olm
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

olm: Also initialize all fields when decoding Olm messages.

Browse source 
As a precaution.
This commit is contained in:
Denis Kasak 2021-05-11 13:15:27 +02:00
parent c325db02fc
commit a5efc08ef3
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/message.cpp
View file

@ -206,9 +206,11 @@ void olm::decode_message(
std::uint8_t const * end = input + input_length - mac_length; std::uint8_t const * end = input + input_length - mac_length;
std::uint8_t const * unknown = nullptr; std::uint8_t const * unknown = nullptr;
reader.version = 0;
reader.has_counter = false;
reader.counter = 0;
reader.input = input; reader.input = input;
reader.input_length = input_length; reader.input_length = input_length;
reader.has_counter = false;
reader.ratchet_key = nullptr; reader.ratchet_key = nullptr;
reader.ratchet_key_length = 0; reader.ratchet_key_length = 0;
reader.ciphertext = nullptr; reader.ciphertext = nullptr;
@ -291,6 +293,7 @@ void olm::decode_one_time_key_message(
std::uint8_t const * end = input + input_length; std::uint8_t const * end = input + input_length;
std::uint8_t const * unknown = nullptr; std::uint8_t const * unknown = nullptr;
reader.version = 0;
reader.one_time_key = nullptr; reader.one_time_key = nullptr;
reader.one_time_key_length = 0; reader.one_time_key_length = 0;
reader.identity_key = nullptr; reader.identity_key = nullptr;