timoreo/olm
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

use secureRandom in getRandomKey

Browse source
This commit is contained in:
ylecollen 2017-01-04 09:07:12 +01:00
parent ce9f67d5be
commit 570e8bbe93
1 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
java/android/OlmLibSdk/olm-sdk/src/main/java/org/matrix/olm/OlmUtility.java
View file

@ -20,7 +20,7 @@ package org.matrix.olm;
import android.text.TextUtils;
import android.util.Log;
import java.util.Random;
import java.security.SecureRandom;
/**
* Olm SDK helper class.
@ -138,16 +138,10 @@ public class OlmUtility {
* @return string containing randoms integer values
*/
public static String getRandomKey() {
String keyRetValue;
Random rand = new Random();
StringBuilder strBuilder = new StringBuilder();
for(int i = 0; i< RANDOM_KEY_SIZE; i++) {
strBuilder.append(rand.nextInt(RANDOM_RANGE));
}
keyRetValue = strBuilder.toString();
return keyRetValue;
SecureRandom secureRandom = new SecureRandom();
byte[] buffer = new byte[RANDOM_KEY_SIZE];
secureRandom.nextBytes(buffer);
return new String(buffer);
}
/**